Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Amend #13497 #13577

Merged
merged 2 commits into from Oct 18, 2022
Merged

refactor: Amend #13497 #13577

merged 2 commits into from Oct 18, 2022

Conversation

alexanderbez
Copy link
Contributor

Description

Amend #13497 such that we can still keep the feature while not breaking the existing Application interface.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@alexanderbez alexanderbez enabled auto-merge (squash) October 18, 2022 01:02
Copy link
Collaborator

@robert-zaremba robert-zaremba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Pre Approving, but we need :

  • changelog update
  • docs update and maybe release notes and migration document (explaining that apps should add a new method).

@julienrbrt
Copy link
Member

Thanks! Pre Approving, but we need :

  • changelog update
  • docs update and maybe release notes and migration document (explaining that apps should add a new method).

I think #13497 already added that.

Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@alexanderbez alexanderbez merged commit 8667eba into release/v0.46.x Oct 18, 2022
@alexanderbez alexanderbez deleted the bez/ammend-13485-v0.46.x branch October 18, 2022 07:21
@robert-zaremba
Copy link
Collaborator

I think #13497 already added that.

It doesn't in a right way. Changelog should be updated, stating that the new Interface is introduced. Moreover we should add docs / release notes stating why app should add a new implementation.

robert-zaremba pushed a commit that referenced this pull request Oct 18, 2022
p0mvn pushed a commit to osmosis-labs/cosmos-sdk that referenced this pull request Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants