Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In place migration: auth must be migrated after staking #10606

Closed
4 tasks done
robert-zaremba opened this issue Nov 24, 2021 · 2 comments · Fixed by #10608
Closed
4 tasks done

In place migration: auth must be migrated after staking #10606

robert-zaremba opened this issue Nov 24, 2021 · 2 comments · Fixed by #10608

Comments

@robert-zaremba
Copy link
Collaborator

robert-zaremba commented Nov 24, 2021

Summary of Bug

If auth is migrated before staking, then the vested accounts won't be migrated correctly and be vanished. Solutions:

This issue will target 0.44 only. For 0.45 / master we #10604

Ref:

Steps to Reproduce


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@robert-zaremba
Copy link
Collaborator Author

After a chat with @AmauryM we are rather thinking about enforcing an order in https://github.com/cosmos/cosmos-sdk/blob/v0.44.3/types/module/module.go#L403 rather than doing a hack.

@robert-zaremba
Copy link
Collaborator Author

closed by: #10608

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant