Regarding the application transactions and underlying tendermint consensue

[baok]

HI
By reading the DOC of SDK, I was given the impression that the BeginBlock /DeliverTx/EndBlock/Commit ABCI messages are sent to the application during different phases of the tendermint consensus. The doc states that DeliverTx failure would cause the block proposer to be rejected. But by checking the tendermint code ,I can only see that only during the last phase of consensus where the proposer has received 2/3 votes and tries to do the final committing of the block the tendermint would call the applyBlock which in turn calls the ABCI's BeginBlock()->DeliverTx()->EndBlock()->Commit(). In other words, when BeginBlock is called the consensus has finished and the block production has been determined. So no matter whether DeliverTx() returns a successful code or not, the block would be produced and chained. Albeit it contained the failed application tx. Could someone disabuse me of this confusion?

[alexanderbez]

The doc states that DeliverTx failure would cause the block proposer to be rejected.

Where do the docs state this? Block proposers can include txs in blocks that fail DeliverTx. Currently, there is no punishment for this, but @zmanian is working on an ADR for proposer-based slashing (under certain failure modes, e.g. sig verification failure but not gas failure).

So yes, blocks can and actually do include txs due to failed DeliverTx executions. In fact, you see this on Terra a lot.

[baok]

It states Here.

[alexanderbez]

That section doesn't state the mode, i.e. CheckTx vs DeliverTx. What that statement means is that an honest actor would not propose a block with txs that failed CheckTx. They can, but an honest or correct process wouldn't.

[baok]

Thanks. It is put under DeliverTx section so might still be little confused. Anyway, it would be more accurate if ABCI++ which is still in drafet is adopted. Will the SDK be evolved to use that?

[alexanderbez]

Ahh I see. Yeah, that's not 100% accurate, sorry for the confusion that has given you.

Re ABCI++, yes, 100%. The SDK will update to incorporate ABCI++ once it's officially released in Tendermint v0.36.