From d314a12e688060aab6afa63fa8b12bcd69ecb3bd Mon Sep 17 00:00:00 2001 From: billy rennekamp Date: Thu, 10 Nov 2022 11:02:17 -0500 Subject: [PATCH] fix: bank store migration (#13821) --- x/bank/migrations/v3/store.go | 2 +- x/bank/migrations/v3/store_test.go | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/x/bank/migrations/v3/store.go b/x/bank/migrations/v3/store.go index 5525f0015bff..c5db8553d2b7 100644 --- a/x/bank/migrations/v3/store.go +++ b/x/bank/migrations/v3/store.go @@ -81,7 +81,7 @@ func migrateDenomMetadata(store sdk.KVStore, logger log.Logger) error { for ; oldDenomMetaDataIter.Valid(); oldDenomMetaDataIter.Next() { oldKey := oldDenomMetaDataIter.Key() - l := len(oldKey)/2 + 1 + l := len(oldKey) / 2 newKey := make([]byte, len(types.DenomMetadataPrefix)+l) // old key: prefix_bytes | denom_bytes | denom_bytes diff --git a/x/bank/migrations/v3/store_test.go b/x/bank/migrations/v3/store_test.go index 3b2697267091..52e9efdcd324 100644 --- a/x/bank/migrations/v3/store_test.go +++ b/x/bank/migrations/v3/store_test.go @@ -89,8 +89,8 @@ func TestMigrateDenomMetaData(t *testing.T) { denomMetadataStore := prefix.NewStore(store, v2.DenomMetadataPrefix) for i := range []int{0, 1} { - key := append(v2.DenomMetadataPrefix, []byte(metaData[i].Base)...) // keys before 0.45 had denom two times in the key + key := append([]byte{}, []byte(metaData[i].Base)...) key = append(key, []byte(metaData[i].Base)...) bz, err := encCfg.Codec.Marshal(&metaData[i]) require.NoError(t, err) @@ -107,11 +107,11 @@ func TestMigrateDenomMetaData(t *testing.T) { newKey := denomMetadataIter.Key() // make sure old entry is deleted - oldKey := append(newKey, newKey[1:]...) + oldKey := append(newKey, newKey[0:]...) bz := denomMetadataStore.Get(oldKey) require.Nil(t, bz) - require.Equal(t, string(newKey)[1:], metaData[i].Base, "idx: %d", i) + require.Equal(t, string(newKey), metaData[i].Base, "idx: %d", i) bz = denomMetadataStore.Get(denomMetadataIter.Key()) require.NotNil(t, bz) err := encCfg.Codec.Unmarshal(bz, &result)