Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type URLs for x/authz messages not present #408

Open
AmitPr opened this issue Jun 6, 2023 · 4 comments
Open

Type URLs for x/authz messages not present #408

AmitPr opened this issue Jun 6, 2023 · 4 comments

Comments

@AmitPr
Copy link

AmitPr commented Jun 6, 2023

In cosmos-sdk-proto, I'm not seeing any Type URL implementations for any of the messages in the x/authz module. For example, MsgGrant, or GenericAuthorization.

@DaviRain-Su
Copy link
Contributor

https://github.com/cosmos/cosmos-rust/blob/main/cosmos-sdk-proto/src/type_urls.rs This file maybe have not impl for the type.

@tony-iqlusion
Copy link
Member

Yeah, right now adding the type URLs is a manual process unfortunately.

I opened an upstream PR which attempts to upstream some of the work from these crates so it can be automated with prost-build: tokio-rs/prost#858

@AmitPr
Copy link
Author

AmitPr commented Jun 6, 2023

Gotcha. Yeah it's not a super big deal even now as I can manually input the Type URLs when serializing to any. Just would be nice to have this all consistent!

@tony-iqlusion
Copy link
Member

tony-iqlusion commented Jun 6, 2023

As a stopgap we could possibly add something to proto-build, otherwise PRs accepted if someone wants to add the type URLs by hand.

Edit: see #409 for discussion of using prost-build to auto-generate these.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants