Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable no-std and replate cosmos-sdk-proto to ibc-proto #404

Closed
wants to merge 12 commits into from

Conversation

DaviRain-Su
Copy link
Contributor

close: #397 #398

At present, one of the issues that needs to be addressed is to ensure that the versions of the proto files generated for cosmos sdk, ibc, and wasmd in ibc-proto correspond to the current library.

The overall changes have been made to support no-std in cosmrs, replaced cosmos-sdk-proto with ibc-proto. As for the error handling, I'm not sure if it meets your requirements or if you have any suggestions.

@DaviRain-Su DaviRain-Su changed the title New proto enable no-std and replate cosmos-sdk-proto to ibc-proto May 11, 2023
@tony-iqlusion
Copy link
Member

This PR seems to be combining a number of different changes, including rather huge, sweeping, and controversial ones like completely deleting cosmos-sdk-proto.

I think something like retiring cosmos-sdk-proto and naming ibc-proto as its official successor is a much, much bigger discussion, and especially shouldn't be mixed into other changes like trying to add no_std support to cosmrs.

@DaviRain-Su
Copy link
Contributor Author

DaviRain-Su commented May 11, 2023

i can spilt. Completely delete cosmos sdk proto because it does not support no std. I want to use ibc proto directly instead. I think it can also merge the proto that two different projects depend on to minimize multiple repositories.

@tony-iqlusion
Copy link
Member

tony-iqlusion commented May 11, 2023

That's a political decision as much as it is a technical one.

You need to get buy in from both maintainers to merge the two projects, and then there's a question of where the resulting code lives.

Also, right now this project benefits from having a "monorepo" where we can make cross-cutting changes between cosmos-sdk-proto and cosmrs, which is something we'd lose if this project switched to using ibc-proto. That's a pretty major disadvantage.

Retiring cosmos-sdk-proto would also force many downstream users to migrate, which would create a lot of churn. I am definitely not convinced it's a good idea.

@DaviRain-Su
Copy link
Contributor Author

I'm currently implementing ics06 solomachine. I want to use the pullickey type in cosmrs directly. I don't want to reimplement it in ibc-rs. I think there will be more problems with ibc-rs and cosmrs intersecting in the future

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable cosmrs support no_std
2 participants