Bump tendermint-rs crates to v0.26; MSRV 1.59 #302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tony-iqlusion
commented
Nov 1, 2022
| let attempts = 5; | ||
|
|
||
| // TODO(tarcieri): better conversion or unified `Hash` type, see tendermint-rs#1221 |
There was a problem hiding this comment.
tony-iqlusion
commented
Nov 1, 2022
| @@ -178,7 +178,13 @@ impl Tx { | |||
| where | |||
| C: rpc::Client + Send + Sync, | |||
| { | |||
| let response = rpc_client.tx(tx_hash, false).await?; | |||
| // TODO(tarcieri): better conversion or unified `Hash` type, see tendermint-rs#1221 | |||
There was a problem hiding this comment.
tomtau
approved these changes
Nov 1, 2022
|
plus MSRV bump is needed ed14ea0 |
tony-iqlusion
force-pushed
the
tendermint-v0.16
branch
from
ac1c6f5
to
f3dc60c
Compare
tony-iqlusion
changed the title
tony-iqlusion
force-pushed
the
tendermint-v0.16
branch
2 times, most recently
from
70a02d0
to
11290d9
Compare
This release removes the need to pin to specific versions, allowing the requirements to shift to `^`. It includes some changes related to the elimination of `tendermint::abci`, namely `Gas` is now aliased to `u64`, `Data` is aliased to `Vec<u8>`, and `Hash` uses `tendermint::Hash`.
tony-iqlusion
force-pushed
the
tendermint-v0.16
branch
from
11290d9
to
de31e70
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This release removes the need to pin to specific versions, allowing the requirements to shift to
^.It includes some changes related to the elimination of
tendermint::abci, namelyGasis now aliased tou64,Datais aliased toVec<u8>, andHashusestendermint::Hash.cc @tomtau