Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace elliptic with noble-secp256k1 #1272

Open
paulmillr opened this issue Sep 19, 2022 · 2 comments 路 May be fixed by #1348
Open

Replace elliptic with noble-secp256k1 #1272

paulmillr opened this issue Sep 19, 2022 · 2 comments 路 May be fixed by #1348
Milestone
0.33.0

Comments

@paulmillr
Copy link

It's time! Ethereum and Solana already did. 馃槂
@paulmillr paulmillr mentioned this issue Sep 19, 2022
Closed
@webmaster128
Copy link
Member

Paul, love your work, thanks a lot! We use noble-hashing already. It will be done.

@webmaster128 webmaster128 added this to the 0.30.0 milestone Oct 17, 2022
@webmaster128 webmaster128 linked a pull request Dec 8, 2022 that will close this issue
Draft
@webmaster128
Copy link
Member

The migration is done in #1348. Looks nice and clean!

The only drawback I see is pulling in the Node.js crypto module again which we are just getting rid of. I opened paulmillr/noble-secp256k1#84 for this.

@webmaster128 webmaster128 modified the milestones: 0.30.0, 0.31.0 Mar 2, 2023
@webmaster128 webmaster128 modified the milestones: 0.31.0, 0.32.0 Jun 19, 2023
@webmaster128 webmaster128 modified the milestones: 0.32.0, 0.33.0 Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.33.0
Development

Successfully merging a pull request may close this issue.

Migrate to @noble/secp256k1 cosmos/cosmjs
2 participants
@paulmillr @webmaster128