Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Batch RPC requests #1300

Closed
wants to merge 15 commits into from
Closed

Batch RPC requests #1300

wants to merge 15 commits into from

Conversation

codehans
Copy link
Contributor

Proof of concept re #1298

@codehans codehans mentioned this pull request Oct 20, 2022
Closed
@codehans
Copy link
Contributor Author

codehans commented Oct 21, 2022 •
edited

@webmaster128 PR updated. httpbatchclient has a dependency on the http in httpclient now, can pull that out into something shared if need be. figured that if batch may become the default then this may be unnecessary

webmaster128
webmaster128 reviewed Oct 24, 2022
View reviewed changes
Copy link
Member

@webmaster128 webmaster128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful

packages/tendermint-rpc/src/rpcclients/httpbatchclient.spec.ts Outdated Show resolved Hide resolved
packages/tendermint-rpc/src/rpcclients/httpbatchclient.ts Outdated Show resolved Hide resolved
packages/tendermint-rpc/src/rpcclients/httpbatchclient.ts Outdated Show resolved Hide resolved
packages/tendermint-rpc/src/rpcclients/httpbatchclient.ts Show resolved Hide resolved
packages/tendermint-rpc/src/rpcclients/httpbatchclient.ts Outdated Show resolved Hide resolved
codehans and others added 5 commits October 24, 2022 10:10
@codehans @webmaster128
Update packages/tendermint-rpc/src/rpcclients/httpbatchclient.spec.ts
e0f1f83 
Co-authored-by: Simon Warta <2603011+webmaster128@users.noreply.github.com>
@codehans @webmaster128
Update packages/tendermint-rpc/src/rpcclients/httpbatchclient.ts
09b8623 
Co-authored-by: Simon Warta <2603011+webmaster128@users.noreply.github.com>
@codehans @webmaster128
Update packages/tendermint-rpc/src/rpcclients/httpbatchclient.ts
00f0fd4 
Co-authored-by: Simon Warta <2603011+webmaster128@users.noreply.github.com>
@codehans
review updates
cf7887a
@codehans
lint
2b6782b
webmaster128
webmaster128 reviewed Oct 24, 2022
View reviewed changes
Copy link
Member

@webmaster128 webmaster128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Just the truethyness for now.

Can you add a CHANGELOG.md entry to the unreleased section? Then we can ship this in the next patch release this week.

packages/tendermint-rpc/src/rpcclients/httpbatchclient.ts Show resolved Hide resolved
packages/tendermint-rpc/src/rpcclients/httpbatchclient.ts Outdated Show resolved Hide resolved
webmaster128
webmaster128 reviewed Oct 24, 2022
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
webmaster128
webmaster128 reviewed Oct 24, 2022
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
codehans and others added 2 commits October 24, 2022 10:55
@codehans @webmaster128
Update CHANGELOG.md
7d19089 
Co-authored-by: Simon Warta <2603011+webmaster128@users.noreply.github.com>
@codehans @webmaster128
Update CHANGELOG.md
78c60f9 
Co-authored-by: Simon Warta <2603011+webmaster128@users.noreply.github.com>
webmaster128
webmaster128 reviewed Oct 24, 2022
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@webmaster128 webmaster128 marked this pull request as ready for review October 24, 2022 09:59
webmaster128
webmaster128 approved these changes Oct 24, 2022
View reviewed changes
Copy link
Member

@webmaster128 webmaster128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice stuff!

Any last changes from your side? Otherwise I merge and ship with the next patch release. Then we can start testing it in real apps.

@codehans
Copy link
Contributor Author

Nice stuff!

Any last changes from your side? Otherwise I merge and ship with the next patch release. Then we can start testing it in real apps.

nothing from my side, all good!

actually just deployed it to our live apps (https://blue.kujira.app, https://fin.kujira.app)

@webmaster128 webmaster128 added this to the 0.29.x milestone Oct 24, 2022
@webmaster128 webmaster128 mentioned this pull request Oct 24, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@webmaster128 webmaster128 webmaster128 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.29.x
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@codehans @webmaster128