Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Type hint project #275

Open
HitLuca opened this issue Sep 2, 2020 · 2 comments · May be fixed by #306
Open

Type hint project #275

HitLuca opened this issue Sep 2, 2020 · 2 comments · May be fixed by #306

Comments

@HitLuca
Copy link

HitLuca commented Sep 2, 2020

I use this project for all my apis, and I would see a benefit in having it fully type hinted for use with type checkers like mypy. Given that it's not a very big project it shouldn't take much work and it's something that doesn't bring downsides that I'm aware of
@mdantonio
Copy link

That would be very useful!

@HitLuca
Copy link
Author

HitLuca commented Mar 3, 2022

Since it's a year+ old issue, I can suggest using monkeytype to generate type hints, based on running the project's tests and generating type hints from them. If I have the time I will try to push a PR

@HitLuca HitLuca linked a pull request Mar 3, 2022 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added type hints to most classes using mokeytype HitLuca/flask-cors
2 participants
@HitLuca @mdantonio