Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Universal wheels #175

Merged
merged 2 commits into from Aug 18, 2016
Merged

Conversation

joshfriend
Copy link
Contributor

Right now, there is only a py2 wheel being released. This PR will cause bdist_wheel to build a universal py2.py3 wheel instead. It also tells the Travis release task to upload the wheel to PyPI in addition to the sdist which is the only one uploaded by default

@corydolphin
Copy link
Owner

Awesome, this is great.

Thanks so much for your help @joshfriend! Once tests pass, I'll merge it up.

@corydolphin
Copy link
Owner

Also, since you appear to be a Travis wizard, any ideas why 2.1.3 did not build on Travis? I'm out of ideas.

@coveralls
Copy link

coveralls commented Aug 18, 2016

Coverage Status

Changes Unknown when pulling 8703b11 on joshfriend:universal-wheels into * on corydolphin:master*.

4 similar comments
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 8703b11 on joshfriend:universal-wheels into * on corydolphin:master*.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 8703b11 on joshfriend:universal-wheels into * on corydolphin:master*.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 8703b11 on joshfriend:universal-wheels into * on corydolphin:master*.

@coveralls
Copy link

coveralls commented Aug 18, 2016

Coverage Status

Changes Unknown when pulling 8703b11 on joshfriend:universal-wheels into * on corydolphin:master*.

@coveralls
Copy link

coveralls commented Aug 18, 2016

Coverage Status

Changes Unknown when pulling 8703b11 on joshfriend:universal-wheels into * on corydolphin:master*.

@joshfriend
Copy link
Contributor Author

Wow, chill out coveralls! ;)

Tag 2.1.3 is commit a2188d0:

$ git show-ref --tags | grep 2.1.3
a2188d0aeb02c03ba8e71d004acd68699bba82ed refs/tags/2.1.3

However, I don't see any travis builds for that commit sha. There are 4 builds in the log that have the a commit message related to #150, but none of those is for the tagged commit. Since that PR has only 2 commits on it, I suspect some merging and force pushing caused travis to miss building that commit somehow?

@corydolphin corydolphin merged commit 4674c3d into corydolphin:master Aug 18, 2016
@joshfriend joshfriend deleted the universal-wheels branch August 18, 2016 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants