Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up Facility registration form #7758

Open
5 tasks
aparnacoronasafe opened this issue May 6, 2024 · 9 comments · May be fixed by #7796
Open
5 tasks

Clean up Facility registration form #7758

aparnacoronasafe opened this issue May 6, 2024 · 9 comments · May be fixed by #7796
Assignees
@609harsh
Labels
good first issue Good for newcomers work-in-progress

Comments

@aparnacoronasafe
Copy link
Member

Is your feature request related to a problem? Please describe.
Details of oxygen storage and consumption may not be very relevant for many facilities registered in CARE.

Hence the data input fields may be moved to a separate section in the facility dashboard https://care.coronasafe.in/facility/40ff580a-b37f-4738-b74c-25073d6b1288 (like the bed capacity and doctor's list)

Describe the solution you'd like

Screenshot 2024-05-06 at 3 12 54 PM
  • On facility dashboard edit the title "Oxygen Information" to "Details on oxygen supply and consumption"
  • Add button to "Add details"
  • Pop-up to be added (design consistent with "Bed Capacity") Pop-up title "Add oxygen details" with
  • Type of oxygen (dropdown with "Liquid Oxygen, Type B cylinder, Type C cylinder, Type D cylinder"
  • Field for Max. Capacity and Expected burn rate to be added on the Pop-up window
  • Visualisation of the details to be kept in consistent with the visualisation of bed capacity and doctors list.
@aparnacoronasafe aparnacoronasafe added the good first issue Good for newcomers label May 6, 2024
@609harsh
Copy link
Contributor

609harsh commented May 6, 2024 •
edited

hey @rithviknishad please assign this issue to me.

@609harsh
Copy link
Contributor

609harsh commented May 6, 2024

@rithviknishad for oxygen do we have any icon already at add oxygen details button?
image

@rithviknishad
Copy link
Member

Couldn't find one specific to oxygen/cylinder. You could use the same one as the one used in the "Add Triage" button.

@609harsh
Copy link
Contributor

609harsh commented May 7, 2024

Hi @rithviknishad, we need 4 new api endpoints (Get,Post,Put,Delete) for Oxygen Section at facility home page. can i create those or do i have to raise a issue?

Also while making Post api call at update facility button should we remove oxygen data that we are sending (as in ui we have removed) or keep default values to be 0. since if we remove oxygen related data for api call i guess we will also need to update that endpoint.

@rithviknishad
Copy link
Member

You could simply use the existing PATCH facility api instead right?

@609harsh
Copy link
Contributor

609harsh commented May 7, 2024

@rithviknishad this one?
image

@rithviknishad
Copy link
Member

Yup!

@609harsh
Copy link
Contributor

609harsh commented May 7, 2024

and what about fetching oxygen details?
should i use this
image

@rithviknishad
Copy link
Member

You don't need to fetch anything right? The parent component which is the facility details page, already would have fetched the facility record right? Just pass it down as a prop?

@609harsh 609harsh linked a pull request May 11, 2024 that will close this issue
Open
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@609harsh 609harsh

Labels
good first issue Good for newcomers work-in-progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Removed Oxygen Details from Update Facility form 609harsh/os_care_fe
3 participants
@rithviknishad @aparnacoronasafe @609harsh