Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving usages of font sizes to respect browser's font size preference #7753

Closed
1 task
rithviknishad opened this issue May 4, 2024 · 1 comment · Fixed by #7770
Closed
1 task

Improving usages of font sizes to respect browser's font size preference #7753

rithviknishad opened this issue May 4, 2024 · 1 comment · Fixed by #7770
Assignees
Labels

Comments

@rithviknishad
Copy link
Member

rithviknishad commented May 4, 2024

Summary

In CARE, font sizes are mostly relative and hence respect browsers preferred font sizes. However, in some places, font sizes are absolute and hence do not respect the preferred font size set by the user's browser.

One such example is the "beta" label for the Daily Rounds which is hard-coded at 10px.

  • At "Very Large" browser font size:
image
  • At "Medium" (default) browser font size:
image

This same issue is present in a couple of other places as well.

Action Items

  • Replace the font size to be relative (use rem values) instead of absolute pixels, to respect the browser's font size preference.

Ref: https://tailwindcss.com/docs/font-size

Notes

To find all such occurrences, use regex search in your IDE, and search for: text-\[.*px\]

image
@rithviknishad rithviknishad changed the title Improving usages of font sizes in CARE Improving usages of font sizes in CARE to respect browser's font size preference May 4, 2024
@rithviknishad rithviknishad changed the title Improving usages of font sizes in CARE to respect browser's font size preference Improving usages of font sizes to respect browser's font size preference May 4, 2024
@Ashutosh0602
Copy link
Contributor

I would to work on this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants