Skip to content
This repository has been archived by the owner on Aug 14, 2021. It is now read-only.

Random CI Runs missing env vars #487

Open
mattvb91 opened this issue Mar 18, 2021 · 6 comments · Fixed by #508
Open

Random CI Runs missing env vars #487

mattvb91 opened this issue Mar 18, 2021 · 6 comments · Fixed by #508
Assignees
Labels
bug Something isn't working

Comments

@mattvb91
Copy link
Member

For some reason our current CI runs are sometimes dropping env variables we pass in as secrets. In this case its affecting our FaunaDB initialization as the secret key is missing on the running container.

Failed run
https://github.com/corejam/corejam/runs/2138006636?check_suite_focus=true#step:9:7

  env:
    SECRET_KEY: 
    GITHUB_SHA: a8798fc2e260fea2c478340897010deaf2623b99

Success run:
https://github.com/corejam/corejam/runs/2137791179?check_suite_focus=true#step:9:7

  env:
    SECRET_KEY: ***
    GITHUB_SHA: 9e48b932079767b7917bed95e7a4915376fbd3cc

No changes were made to the secrets through admin settings so this is either a github actions bug or something else?

@mattvb91 mattvb91 added the bug Something isn't working label Mar 18, 2021
@mattvb91 mattvb91 self-assigned this Mar 18, 2021
@mattvb91
Copy link
Member Author

@mattvb91
Copy link
Member Author

@mattvb91 mattvb91 pinned this issue Mar 22, 2021
@mattvb91
Copy link
Member Author

@patrickhaug can you add the NPM secret you added for the releases on the new "dependabot" tab for secrets under settings. But make sure to add it into organization level

@patrickhaug
Copy link
Contributor

We could wait for #402 and get rid of fauna ..

@mattvb91
Copy link
Member Author

mattvb91 commented Apr 1, 2021

We will still have fauna tests tho?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants