This repository has been archived by the owner on Aug 14, 2021. It is now read-only.
put env replace in corejam rollup #471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## next #471 +/- ##
==========================================
+ Coverage 80.07% 80.16% +0.08%
==========================================
Files 147 148 +1
Lines 2008 2012 +4
Branches 313 313
==========================================
+ Hits 1608 1613 +5
+ Misses 316 315 -1
Partials 84 84
Continue to review full report at Codecov.
|
mattvb91
reviewed
Mar 13, 2021
| DEPLOYMENT_URL=http://localhost:3000 |
There was a problem hiding this comment.
Suggested change
| DEPLOYMENT_URL=http://localhost:3000 | |
| API_ORIGIN=http://localhost:3000 |
mattvb91
reviewed
Mar 13, 2021
packages/p2p/.env.sample
Outdated
| DEPLOYMENT_URL=http://localhost:3000 |
There was a problem hiding this comment.
Suggested change
| DEPLOYMENT_URL=http://localhost:3000 | |
| API_ORIGIN=http://localhost:3000 |
added 2 commits
March 13, 2021 10:25
|
still receiving the #466 warning here Edit: nevermind didnt have clean state |
mattvb91
approved these changes
Mar 13, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #466
Assignement is now to true, since next major is true per default.
fixes #399
Env vars are looped over now automatically.
todo:
[X] write env var to safe env wrapper
[X] include lint rule to not call process.env
fixes #395