Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regression_tests_added50: why is a URL required? #1994

Open
ljharb opened this issue Jul 12, 2023 · 2 comments
Open

regression_tests_added50: why is a URL required? #1994

ljharb opened this issue Jul 12, 2023 · 2 comments

Comments

@ljharb
Copy link

ljharb commented Jul 12, 2023

I can't figure out what possible URL could make sense here, since I'm not sure how you'd programmatically verify that a specific bugfix that added tests actually added regression tests for that bug. I ended up just pointing to the list of merged PRs, but I think the URL requirement should just be removed.

@david-a-wheeler
Copy link
Collaborator

Got it. I was thinking this would point to a policy (e.g., CONTRIBUTING.md or something about testing). Obviously having to manually re-do some analysis isn't reasonable. It'd be possible to create such analysis, but that would require doing a lot of work (carefully labelling bug fixes, doing the analysis, etc.), and that wasn't what I meant. But I guess that isn't clear enough.

I propose adding some text about that, we'll need to get review.

@ljharb
Copy link
Author

ljharb commented Aug 25, 2023

That works for me; i'll update my project to point to the policy :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants