Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove unreachable code #826

Merged
merged 1 commit into from Sep 30, 2022
Merged

refactor: remove unreachable code #826

merged 1 commit into from Sep 30, 2022

Conversation

sisp
Copy link
Member

@sisp sisp commented Sep 28, 2022 •
edited

I've removed unreachable code in an if condition that handles a question choice format that isn't supported.

The handled format is:

choices:
  - name: ...  # <--
    value: ... # <--
  - ...

# or

choices:
  key:
    name: ...  # <--
    value: ... # <--
  ...

yajo
yajo approved these changes Sep 30, 2022
View reviewed changes
Copy link
Member

@yajo yajo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, thanks!

@yajo yajo merged commit c0410b2 into copier-org:master Sep 30, 2022
@sisp sisp deleted the refactor/remove-unreachable-code branch September 30, 2022 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yajo yajo yajo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sisp @yajo