From 6757dfb5329ce96be8839cd19670bcf4f7cd100f Mon Sep 17 00:00:00 2001 From: Semir Patel Date: Wed, 3 Feb 2021 16:14:41 -0800 Subject: [PATCH 1/5] Migrate to github actions --- .github/workflows/ci.yml | 24 ++++++++++++++++++++++++ .travis.yml => travis.yml | 0 2 files changed, 24 insertions(+) create mode 100644 .github/workflows/ci.yml rename .travis.yml => travis.yml (100%) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml new file mode 100644 index 00000000..6360213b --- /dev/null +++ b/.github/workflows/ci.yml @@ -0,0 +1,24 @@ +--- +name: build +on: push +jobs: + make: + runs-on: ubuntu-18.04 + strategy: + fail-fast: false + matrix: + tox: + - py27 + - py36 + - py37 + - pre-commit + - mypy + - docs + # TODO: benchmark + steps: + - uses: actions/checkout@v2 + - uses: actions/setup-python@v2 + with: + python-version: 3.7 + - run: pip install tox coveralls + - run: tox -e ${{ matrix.tox }} diff --git a/.travis.yml b/travis.yml similarity index 100% rename from .travis.yml rename to travis.yml From 8e508a3b7cedb8b25717eb7fd00568844a6ec531 Mon Sep 17 00:00:00 2001 From: Semir Patel Date: Wed, 3 Feb 2021 16:24:31 -0800 Subject: [PATCH 2/5] Fix mypy failure --- .github/workflows/ci.yml | 2 +- tests/exception/__init__.py | 0 2 files changed, 1 insertion(+), 1 deletion(-) create mode 100644 tests/exception/__init__.py diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 6360213b..1c10aff6 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -2,7 +2,7 @@ name: build on: push jobs: - make: + tox: runs-on: ubuntu-18.04 strategy: fail-fast: false diff --git a/tests/exception/__init__.py b/tests/exception/__init__.py new file mode 100644 index 00000000..e69de29b From 0a771728e8446a20003ffb0146d9f896eb1035a6 Mon Sep 17 00:00:00 2001 From: Semir Patel Date: Wed, 3 Feb 2021 16:38:47 -0800 Subject: [PATCH 3/5] Doc benchmark blocked on "allow-failure" feature --- .github/workflows/ci.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 1c10aff6..78f339c4 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -14,11 +14,11 @@ jobs: - pre-commit - mypy - docs - # TODO: benchmark + # TODO: benchmark blocked on https://github.com/actions/toolkit/issues/399 steps: - uses: actions/checkout@v2 - uses: actions/setup-python@v2 with: python-version: 3.7 - - run: pip install tox coveralls + - run: pip install tox - run: tox -e ${{ matrix.tox }} From f42cf2407b0187274c823304cd9db8e4e82b336d Mon Sep 17 00:00:00 2001 From: Semir Patel Date: Thu, 4 Feb 2021 08:07:48 -0800 Subject: [PATCH 4/5] Update readme badge for build --- README.rst | 4 ++-- tox.ini | 2 +- travis.yml | 26 -------------------------- 3 files changed, 3 insertions(+), 29 deletions(-) delete mode 100644 travis.yml diff --git a/README.rst b/README.rst index 6f70aa15..f4b90319 100644 --- a/README.rst +++ b/README.rst @@ -1,5 +1,5 @@ -.. image:: https://img.shields.io/travis/Yelp/bravado-core/master.svg?label=Linux+Build - :target: https://travis-ci.org/Yelp/bravado-core?branch=master +.. image:: https://github.com/Yelp/bravado-core/workflows/build/badge.svg?branch=master + :target: https://github.com/Yelp/bravado-core/actions?query=workflow%3Abuild .. image:: https://img.shields.io/coveralls/Yelp/bravado-core.svg :target: https://coveralls.io/r/Yelp/bravado-core diff --git a/tox.ini b/tox.ini index 876aa910..c369757a 100644 --- a/tox.ini +++ b/tox.ini @@ -30,7 +30,7 @@ commands = [testenv:docs] deps = # we're getting an error on travis with Sphinx 1.8.0, so we use a lower version - sphinx < 1.8.0 + sphinx # < 1.8.0 sphinx-rtd-theme changedir = docs commands = sphinx-build -b html -d build/doctrees source build/html diff --git a/travis.yml b/travis.yml deleted file mode 100644 index 1148ae41..00000000 --- a/travis.yml +++ /dev/null @@ -1,26 +0,0 @@ -language: python -os: linux - -python: "3.7" - -jobs: - include: - - python: "2.7" - - python: "3.6" - - python: "3.7" - env: PUBLISH_COVERAGE=y - - env: TOXENV=docs - - env: TOXENV=pre-commit - - env: TOXENV=benchmark - - env: TOXENV=mypy - allow_failures: - - env: TOXENV=benchmark - fast_finish: true - -install: pip install tox tox-travis coveralls -script: tox -after_success: | - if [ "${PUBLISH_COVERAGE:-n}" == "y" ]; then coveralls; fi - if [ "${TOXENV}" == "benchmark" ]; then - echo $(ls .benchmarks/*/0001_benchmark.json) $(cat .benchmarks/*/0001_benchmark.json | nc termbin.com 9999) - fi From 9a89e6eb7e3a085162b68680af3e220e7b360bbc Mon Sep 17 00:00:00 2001 From: Semir Patel Date: Thu, 4 Feb 2021 09:18:43 -0800 Subject: [PATCH 5/5] Don't constrain sphinx since it seems to have no issues on github actions --- tox.ini | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/tox.ini b/tox.ini index c369757a..ce08dbb2 100644 --- a/tox.ini +++ b/tox.ini @@ -29,8 +29,7 @@ commands = [testenv:docs] deps = - # we're getting an error on travis with Sphinx 1.8.0, so we use a lower version - sphinx # < 1.8.0 + sphinx sphinx-rtd-theme changedir = docs commands = sphinx-build -b html -d build/doctrees source build/html