Added: Path templates will be rendered when copy_without_render used

[noirbizarre]

This pull-request ensures paths variables are rendered when using _copy_without_render.

It should fix #456.

It does not keep the existing behavior as it was inconsistent, different for files and directories (matched files had their path rendered but not the matched directories).
If this behavior should be kept, I'll update this pull-request with a boolean option like _copy_without_render_paths.

[noirbizarre]

Any chance to see that one merged ? It would be great !!!
Should I change something ? ...
Any comment, any review, I'll update so it can be merge 👍

[noirbizarre]

Hi !
@pydanny @audreyr @michaeljoseph @pfmoore @hackebrot 👋
I never had any feedback on this. As this a this a really simple fix to a really annoying issue (to me), I just want to know:

• is there something I need to change ?
• will this be merged ?
• If not, why ?

Any review, any comment, I'll make the changes ASAP !

[theodesp]

I think it looks good @noirbizarre

[michaeljoseph]

Yep, nice fix 😸

[michaeljoseph]

@noirbizarre could we please have a small update to the docs to include a note about the path vs file content behaviour of this functionality.
Perhaps with an explanatory example?

[noirbizarre]

Done.
@michaeljoseph @theodesp Sorry for the late response, I just noticed yours

[hackebrot]

Looks good! Thank you 🙇

Minor docs fix.

[hackebrot]

I wonder if we should treat this as a breaking change... 🤔

@audreyr @pydanny @michaeljoseph

[noirbizarre]

I fixed the typo.

My opinion: I don't think this should be considered as a breaking change but as a fix because the previous behavior was inconsistent (different behavior for files and directories) and unless you are making a meta cookiecutter (ie. a cookiecutter template rendering cookiecutter templates), I don't think there is any reason to render brackets into path (which was the behavior for directories before this fix because path variables were not rendered).

[noirbizarre]

@audreyr @pydanny @michaeljoseph @theodesp @hackebrot
Could this be merged before the 1.7 is released ?

fixed

[insspb]

@noirbizarre Thank you for contribution. Nothing lost. Merged after 4 year in queue :)

[newlog]

Thanks for this change.