Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.0.0 #410

Closed
pydanny opened this issue Mar 12, 2015 · 18 comments
Closed

Release 1.0.0 #410

pydanny opened this issue Mar 12, 2015 · 18 comments

Comments

@pydanny
Copy link
Member

pydanny commented Mar 12, 2015

I would like to close out this release cycle in the next few days. If there are any bug fixes (no features!) that really should get in, please list them in the comments.

@michaeljoseph
Copy link
Contributor

I'm happy with completing the conversion to pytest and getting 1.0.0 out the door!

@hackebrot
Copy link
Member

So am I. 😄

I'll look into the conflicts with #334 and #337 in a bit.

@hackebrot
Copy link
Member

#334 👌

Am I right that we are not getting coverage comments any more in the PRs? According to my local check it's still at 96%.

@hackebrot
Copy link
Member

Once we got #337 in and completely removed test_main.py we can close #343.

@hackebrot
Copy link
Member

#337 👌

I merged #334 into it, so merging into master shouldn't be a problem after you accepted #337.

@hackebrot
Copy link
Member

Looking through the remaining unittest tests, I noticed that test_config.py still exists although I completely removed it in b7b96f9 in the course of #345. Apparently something went wrong with the merge as I don't find the commit on master. 😢

Other than that there are a few modules left that use unittest:

  • test_hooks.py
  • test_utils.py
  • test_vcs.py

Additional notes:

  • __init__.py can be removed as soon as we don't use CookiecutterCleanSystemTestCase anymore
  • test_arg_parsing.py can be removed as @pydanny stated in a550efa
  • the history of test_prompt.py got deleted by a550efa. I don't think it's a huge problem though. Do you agree?

@hackebrot
Copy link
Member

test_hooks.py #412 😹

@hackebrot
Copy link
Member

test_utils.py #413

@hackebrot
Copy link
Member

test_vcs.py #414 😤

@pydanny
Copy link
Member Author

pydanny commented Mar 15, 2015

Any other bugfixes that should get in? Perhaps #405?

@hackebrot
Copy link
Member

Apparently #405 breaks on Python 3 https://travis-ci.org/audreyr/cookiecutter/builds/53786422

@hackebrot
Copy link
Member

There are still some PRs open for the milestone:

@pydanny
Copy link
Member Author

pydanny commented Mar 16, 2015

Okay, everything is either merged in or pushed to the 1.1.0 release. I am commencing the 1.0.0 release!

@pydanny
Copy link
Member Author

pydanny commented Mar 16, 2015

@hackebrot
Copy link
Member

Great! 😄

HISTORY.rst contains a broken link to @marctc. The reference misses the '@' symbol.

Can we possibly change the description in HISTORY.rst from

Lay the foundation for py.test fixtures and convert test_generate.py and test_examples.py

to something along the lines of

Convert the unittest suite to py.test for the sake of comprehensibilty


I'm sure you'll come up with something better than this. I'm basicly sleeping already 😪

@pydanny
Copy link
Member Author

pydanny commented Mar 16, 2015

@marctc is linked properly now. Also changed the py.test text as you requested. 😄

@pydanny pydanny closed this as completed Mar 16, 2015
@hackebrot
Copy link
Member

Thank you, Sir! 🙇

@marctc
Copy link

marctc commented Mar 23, 2015

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants