Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove remaining typing errors #2058

Open
4 of 6 tasks
danieleades opened this issue Apr 6, 2024 · 3 comments
Open
4 of 6 tasks

remove remaining typing errors #2058

danieleades opened this issue Apr 6, 2024 · 3 comments

Comments

@danieleades
Copy link
Contributor

danieleades commented Apr 6, 2024

tracking issue for addressing the remaining type errors

@danieleades
Copy link
Contributor Author

danieleades commented Apr 7, 2024

@jensens what "shape"/type is the 'prompts' object in the code?

Is this a reasonable reference: https://cookiecutter.readthedocs.io/en/stable/advanced/human_readable_prompts.html?

Is the "prompts" key required for every nested dict?

that 'prompts' module is a horrible bit of code (insofar as typing is concerned), i think it's going to take someone with a lot more familiarity with the code base than I to get that ship shape and removed from the whitelist

@danieleades
Copy link
Contributor Author

refactoring cookiecutter.hooks.run_pre_prompt_hook is also going to help, but it's difficult to track the non-local type errors a refactor introduces with so many modules whitelisted. Will revisit once all the open PRs are merged

@danieleades
Copy link
Contributor Author

ping @jensens! There are several PRs ready to merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant