Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement a sanity check to validate the min version of cookiecutter #1855

Open
ericof opened this issue Jun 13, 2023 · 5 comments
Open

Implement a sanity check to validate the min version of cookiecutter #1855

ericof opened this issue Jun 13, 2023 · 5 comments
Assignees
Labels
enhancement This issue/PR relates to a feature request.
Milestone

Comments

@ericof
Copy link
Member

ericof commented Jun 13, 2023

Description:

In a template. support a sanity check for the minimal version of cookiecutter

example:

{
 "__min_version__": "2.2"
}
@ericof ericof added the enhancement This issue/PR relates to a feature request. label Jun 13, 2023
@ericof ericof self-assigned this Jun 13, 2023
@ericof ericof added this to the 2.2.0 milestone Jun 13, 2023
@kurtmckee
Copy link
Member

kurtmckee commented Jun 23, 2023

I like this idea, but it's just an idea, not an implementation.

Would it be an option to release 2.2.0 immediately? I advocate for more frequent releases and less friction to making those releases.

Edit: I'm specifically arguing against adding an idea to the 2.2.0 milestone. The 2.x release series can simply be "merge something, release it", so there's ongoing iterative improvements, faster turnaround times, and tighter feedback loops for features and bugfixes.

Milestones might be more appropriate for v3 and v4 planning.

@ericof ericof modified the milestones: 2.2.0, 3.0.0 Jul 1, 2023
@ericof
Copy link
Member Author

ericof commented Jul 1, 2023

@kurtmckee Moved to 3.0.0 (even though I plan to implement it before)

@ericof
Copy link
Member Author

ericof commented Nov 27, 2023

Probably we should follow the spec added on #1580

@michael-todorovic
Copy link

Hello,
Talking about sanity checks, could it be possible also to check minimal python version but only if it's provided in the template? This could be valuable for hooks :)

Like

{
 "__min_version__": "2.2",
 "__min_python_version": "3.11"
}

@exhuma
Copy link

exhuma commented May 6, 2024

I'm working for a large company with at least 200 developers. I maintain cookie-cutters and recently made use of newer features (f.ex. the __prompt__ variables and using UUIDs) that was added after the devs installed their CC executable.

I'm constantly getting messages now that "Your cookiecutter doesn't work" to which I have to reply: "Your cookiecutter version is too old. Please upgrade".

It's quite annoying and a feature like a "min CC version" would make this much smoother for everyone. The users would get a clear and helpful message instead of ugly error messages and the CC maintainer would not need to tell all the users to upgrade whenever a new feature is leveraged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This issue/PR relates to a feature request.
Projects
None yet
Development

No branches or pull requests

4 participants