Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test_generate_file_verbose_template_syntax_error fixed #1671

Merged
merged 3 commits into from May 29, 2022
Merged

test_generate_file_verbose_template_syntax_error fixed #1671

merged 3 commits into from May 29, 2022

Conversation

MaciejPatro
Copy link
Contributor

Fixes #1655 - relative path that comes directly from Jinja2 TemplateSyntaxError
in some cases is in format "./tests/..." in other "tests/... now both cases
are accepted as a valid outcome.

@MaciejPatro
test_generate_file_verbose_template_syntax_error fixed
980ff08 
Fixes cookiecutter#1655 - relative path that comes directly from Jinja2 TemplateSyntaxError
in some cases is in format "./tests/..." in other "tests/... now both cases
are accepted as a valid outcome.
@MaciejPatro @jurgenwigg
Remove redundant comparison
6eb9ea8 
Co-authored-by: jurgenwigg <53076001+jurgenwigg@users.noreply.github.com>
jurgenwigg
jurgenwigg suggested changes May 16, 2022
View reviewed changes
Copy link
Contributor

@jurgenwigg jurgenwigg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also fix lint issues.

@MaciejPatro
Copy link
Contributor Author

In general the lint problem was unconnected with the tests - it was in the end problem with old version of black tool https://stackoverflow.com/questions/71673404/importerror-cannot-import-name-unicodefun-from-click . I didn't want to mix those things together - but if this helps you - it's fixed.

@jurgenwigg
Copy link
Contributor

Green CI is always good idea :) Thanks for fixing CI

jurgenwigg
jurgenwigg approved these changes May 16, 2022
View reviewed changes
Copy link
Contributor

@jurgenwigg jurgenwigg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix :)

@MaciejPatro
Copy link
Contributor Author

Glad I could help - thank you for the review :) - it's helpful.

@jensens jensens merged commit 69cd155 into cookiecutter:master May 29, 2022
@eruber eruber mentioned this pull request Feb 5, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@att14 att14 att14 approved these changes

@jurgenwigg jurgenwigg jurgenwigg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

test_generate_file_verbose_template_syntax_error fails with ./ difference in path
4 participants
@MaciejPatro @jurgenwigg @att14 @jensens