New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Python version number in cookiecutter --version
and test on Python 3.10
#1621
Fix Python version number in cookiecutter --version
and test on Python 3.10
#1621
Conversation
Co-authored-by: Sahil <sahilflash123@gmail.com>
Co-authored-by: Sahil <sahilflash123@gmail.com>
Co-authored-by: Sahil <sahilflash123@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We reviewed this together over screenshare and I think this looks good, but I welcome others to review this.
I thought f-strings were not supported on Python 2.7 and 3.5, which this project purports it supports. Am I missing something? |
@gotmax23 where did you find references to those legacy python versions? |
It's listed in one of the shields.io badges in the README. I guess that whatever data source it pulls from is outdated. |
Co-authored-by: Sahil <sahilflash123@gmail.com>
Co-authored-by: Sahil <sahilflash123@gmail.com>
Co-authored-by: Sahil <sahilflash123@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙌
Closes #1619
cookiecutter --version
now prints Python 3.10 instead of Python 3.1