New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adopt setuptools-scm packaging #1577
Conversation
Code Climate has analyzed commit f00bed7 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (0% is the threshold). This pull request will bring the total coverage in the repository to 100.0% (0.0% change). View more on Code Climate. |
LGTM. The only thing I don't like about
I discovered this behavior yesterday so I don't have a solution or workaround pip install pip -U
pip install django-user-sessions@https://github.com/jazzband/django-user-sessions/archive/master.zip |
It is expected not to work with git archives because it does not have any clue about which version to use. Git clones work. Is not the only thing not working with git archives. If I remember well microsoft was considering adding some extra metadata to these archives in order to enable consumers to make use of tag information. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ssbarnea 👋 ,
Does this configuration get only the last tag? What about backports?
It will work for maintenance branches too because it will inherit from last tag from current history and generate a Also keep in mind that no release is made without a tag and the tag value. That does not prevent accidents like tagging the wrong version for the branch. Still that part is addressed differently via https://github.com/orgs/cookiecutter/teams/cookiecutter-sentinel/discussions/4 |
Hi @simobasso @ssbarnea @luzfcb it looks like you have done a huge amount of work on attempting to improve packaging of Cookiecutter. The current team that is trying to put out the Cookiecutter 2 release (including myself) is having trouble getting setuptools_scm and build to work properly. We want to use the improved setup that you created here in this pull request, but we just cant get it to work on my computer. Can any of you help us sometime over the next 24 hours over a voice screen share in discord the Cookiecutter Discord? The ideal situation would be for us to use the current setup as-is to the new release, but if we cant figure it out, we will revert this pull request. NOTE: This message was typed by @ozer550 as Audrey is unable to use her hands. |
One direct benefit of this change is that package version is no longer hardcoded and is generated based on last tag.
Related: #1555