Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code duplication in tests #1538

Open
glumia opened this issue Apr 27, 2021 · 0 comments
Open

Code duplication in tests #1538

glumia opened this issue Apr 27, 2021 · 0 comments
Labels
code style This issue/PR relates to the project code style modification

Comments

@glumia
Copy link
Contributor

glumia commented Apr 27, 2021

Check #1516 (comment).

We have some code duplication in our test suite, in particular we miss a single fixture as source of truth of test-config/valid-config.yaml's content. We should check if something similar happens also for the other yaml files.

A good solution could be to create a python file in the test-config directory with fixtures that act as a source of truth for the content of those yaml files.
@simobasso simobasso added the code style This issue/PR relates to the project code style modification label Apr 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code style This issue/PR relates to the project code style modification
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@simobasso @glumia