Should hooks.py:run_script call subprocess.Popen with run_thru_shell=True? #2006
BrianCechmanek
started this conversation in
General
Replies: 0 comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
hooks.run_script() calls python's
subprocess.Popen(shell=True)when running on Windows. Is this necessary? Is this here for a legacy reason and just hasn't caused issue before?The Python Docs suggest against it.
I'm curious because I recently had a lof ot "fun" tracking down an issue that was ultimately because of python calling my default shell and not my current execution shell (anaconda).
Happy to learn why it's needed for Windows systems 😃
Beta Was this translation helpful? Give feedback.
All reactions