Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add .cjs config file #717

Merged
merged 3 commits into from Dec 31, 2021
Merged

Conversation

shirotech
Copy link
Contributor

Fixes #680

@ghost91-
Copy link

Any info on this? Is anything blocking it from being merged? I would love to be able to use the .cjs extension.

@chimericdream
Copy link

Bump. Is there anything in particular holding this up?

tivac added a commit to tivac/xstate-component-tree that referenced this pull request Nov 24, 2021
@lhokktyn
Copy link

lhokktyn commented Dec 21, 2021

👍 Most of our codebases will be moving to ESM so It would be great to have this feature available.

Edit: In the interim, using the API rather than CLI is working as a reasonable workaround, albeit without npx ... capability :)

@codecov-commenter
Copy link

codecov-commenter commented Dec 31, 2021

Codecov Report

Merging #717 (b5e85e6) into master (366a498) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #717   +/-   ##
=======================================
  Coverage   97.49%   97.49%           
=======================================
  Files          25       25           
  Lines        1118     1119    +1     
=======================================
+ Hits         1090     1091    +1     
  Misses         28       28           
Impacted Files Coverage Δ
lib/configuration.js 94.73% <100.00%> (+0.29%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 366a498...b5e85e6. Read the comment docs.

@bcoe bcoe merged commit eceaedf into conventional-changelog:master Dec 31, 2021
@bcoe
Copy link
Member

bcoe commented Dec 31, 2021

@shirotech thanks for the patch 👍

Appologies that this codebase is realtively stagnent these days, I've been working more on:

https://github.com/googleapis/release-please

@lukasreinfurt
Copy link

I can't find this release in the npm registry, any idea why?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

[Request] Add '.cjs' as a valid extension for config files.
7 participants