Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps, ci): Updates nyc and moves to Codecov #701

Merged
merged 2 commits into from Feb 20, 2021

Conversation

jbottigliero
Copy link
Member

@jbottigliero jbottigliero commented Dec 31, 2020

We dropped pushing updates to Coveralls from CI when we moved to GitHub actions. It looks like most of the org is using Codecov as we no longer have Coveralls configured.

  • Removes coveralls integration.
  • Updates GitHub actions to include CodeCov step.
  • Moves OS to strategy matrix – we're now testing across multiple versions of Windows.
  • Related dependency bumps.

  • Once merged we'll need to update required status checks to reflect the new matrix.

@jbottigliero jbottigliero force-pushed the chore-code-coverage branch 3 times, most recently from 55d283e to bf0815d Compare December 31, 2020 01:54
@jbottigliero jbottigliero changed the title wip:chore(deps, ci): Updates nyc and adds Coveralls step to CI wip:chore(deps, ci): Updates nyc and moves to Codecov Dec 31, 2020
@codecov-io
Copy link

codecov-io commented Dec 31, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@f158d6f). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #701   +/-   ##
=========================================
  Coverage          ?   97.71%           
=========================================
  Files             ?       24           
  Lines             ?     1051           
  Branches          ?        0           
=========================================
  Hits              ?     1027           
  Misses            ?       24           
  Partials          ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f158d6f...5501134. Read the comment docs.

@jbottigliero jbottigliero changed the title wip:chore(deps, ci): Updates nyc and moves to Codecov chore(deps, ci): Updates nyc and moves to Codecov Dec 31, 2020
Joe Bottigliero added 2 commits February 20, 2021 09:54
@jbottigliero jbottigliero merged commit 707e1d2 into master Feb 20, 2021
@jbottigliero jbottigliero deleted the chore-code-coverage branch February 20, 2021 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants