Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: updated generate artifacts code snippet #645

Conversation

privatenumber
Copy link
Contributor

Updated the "Committing Generated Artifacts in the Release Commit" section

  • Removed issue reference The issue is 4 years outdated and wasn't particularly helpful.
  • Corrected code snippet The script didn't work (outdated?)
    • There is no hook called release
    • The script is git adding the build files prior to the build that emits them. git add happens before standard-version, and standard-version is what calls the prerelease hook which builds the distribution files.

@codecov-io
Copy link

codecov-io commented Feb 20, 2021

Codecov Report

Merging #645 (5697c4c) into master (707e1d2) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #645   +/-   ##
=======================================
  Coverage   97.71%   97.71%           
=======================================
  Files          24       24           
  Lines        1051     1051           
=======================================
  Hits         1027     1027           
  Misses         24       24           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 707e1d2...5697c4c. Read the comment docs.

@jbottigliero jbottigliero merged commit 843c572 into conventional-changelog:master Feb 20, 2021
@jbottigliero
Copy link
Member

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants