Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update dependency semver to v7 #508

Merged
merged 1 commit into from Jan 26, 2020
Merged

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Dec 14, 2019

This PR contains the following updates:

Package Type Update Change
semver dependencies major 6.3.0 -> 7.1.1

Release Notes

npm/node-semver

v7.1.1

Compare Source

v7.1.0

Compare Source

  • Add require('semver/preload') to load the entire module without using
    lazy getter methods.

v7.0.0

Compare Source

  • Refactor module into separate files for better tree-shaking
  • Drop support for very old node versions, use const/let, => functions,
    and classes.

Renovate configuration

📅 Schedule: At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻️ Rebasing: Whenever PR becomes conflicted, or if you tick the rebase/retry checkbox below.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by WhiteSource Renovate. View repository job log here.

@coveralls
Copy link

coveralls commented Dec 14, 2019

Coverage Status

Coverage remained the same at 99.429% when pulling 8594cf7 on renovate/semver-7.x into c97f85e on master.

@jbottigliero jbottigliero merged commit 2f04ac8 into master Jan 26, 2020
@renovate renovate bot deleted the renovate/semver-7.x branch January 26, 2020 19:31
@kellyselden
Copy link

This drops support for node 8, and your engines still supports it. I just want to make sure you intended this, and your next release is going to be a breaking change. (I'm branched off master and I noticed my yarn install started failing.)

@jbottigliero
Copy link
Member

Hey @kellyselden thanks for the note! We have Travis running our test suite with NodeJS@8 (and other supported engines on both Linux and Windows). What is the error message you see on install? And could you provide your yarn and full NodeJS version?

@kellyselden
Copy link

@jbottigliero Here's the logs https://travis-ci.org/CrowdStrike/monorepo-next/builds/652062253

$ node --version
v8.17.0
$ npm --version
6.13.4
$ nvm --version
0.35.2
$ yarn --version
1.15.2

$ yarn
yarn install v1.15.2
[1/5] Validating package.json...
[2/5] Resolving packages...
[3/5] Fetching packages...
error semver@7.1.1: The engine "node" is incompatible with this module. Expected version ">=10". Got "8.17.0"
error Found incompatible module
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.

@kellyselden
Copy link

@jbottigliero
Copy link
Member

Thanks! Yeah, it looks like it being a warn on the npm install allowed it to pass. NodeJS@8 was just removed from the upstream conventional-changelog... I'm going to take a look at the commit history here, but I think we could probably tag one more release before a major version that introduces this breaking change.

I'll open a ticket to track that work – thanks again, good catch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants