fix: stop suggesting npm publish if package.json was not updated #319
+15
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevemao
approved these changes
Mar 29, 2019
|
@MiniGod agreed, great addition; mind rebasing? |
MiniGod
force-pushed
the
dont-suggest-npm-publish-if-no-package-json
branch
2 times, most recently
from
427b891 to
073ad8b
Compare
|
@MiniGod I apologize for the slow turn around, |
MiniGod
force-pushed
the
dont-suggest-npm-publish-if-no-package-json
branch
from
073ad8b to
f0642f9
Compare
MiniGod
force-pushed
the
dont-suggest-npm-publish-if-no-package-json
branch
from
f0642f9 to
34aadcc
Compare
|
It's ready for you now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
standard-version@5.0.0introduced git tag fallback, but it is still suggestingnpm publisheven ifpackage.jsonwas not updated.Added a check so it doesn't. Could later be generalized for bower and composer, etc...?
Did a small refactor in
bump.jsso that the check would be simpler.