Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gitlab urls are not the good ones #986

Open
sylvainOL opened this issue May 22, 2023 · 3 comments
Open

Gitlab urls are not the good ones #986

sylvainOL opened this issue May 22, 2023 · 3 comments

Comments

@sylvainOL
Copy link

Conventional changelog is using the "legacy" pattern for urls and this pattern is removed in Gitlab 16 which is the version used on cloud (gitlab.com)

The pattern should be: https://gitlab.com/repo_name/-/action/whatever instead of https://gitlab.com/repo_name/action/whatever (add of -/ between repo_name and action).

I tried to findout where it can be in the code but wasn't able to find.

Please note that it's hurting semantic release release note generator (semantic-release/release-notes-generator#449)

@mebibou
Copy link

mebibou commented May 23, 2023

Should have been changed a while back, shame that now all our changelogs point to invalid URLs

Anyway to fix this asap?

tcitworld added a commit to framasoft/mobilizon that referenced this issue May 23, 2023
@milo526
Copy link

milo526 commented May 24, 2023

On gitlab's side, the updating of url is tracked in https://gitlab.com/gitlab-org/gitlab/-/issues/28848

@olwe0002
Copy link

in the meantime GitLab changed its behaviour and redirects to the new URLs instead of failing on the old URLs. But as I understood the comment and the follow up issue, the redirects won't be there forever. So it makes sense to fix the URLs to point to the right ones in any case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

4 participants