Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

conventionalRecommendedBump not returning expected releaseType #952

Open
rrundle-dave opened this issue Dec 21, 2022 · 1 comment
Open

Comments

@rrundle-dave
Copy link

I had a single commit PR that ran this on CI and the only commit was

fix(ci): test number 2

and

    conventionalRecommendedBump({ preset: 'angular' }, (error, recommendation) => {
      console.log('file: helpers.ts:131 ~ recommendation', recommendation);
      console.log('file: helpers.ts:131 ~ error', error);
    })

returned

{
  level: 1,
  reason: 'There are 0 BREAKING CHANGES and 2 features',
  releaseType: 'minor'
}

Of course I'm expecting a patch releaseType not minor.

I've actually tried on multiple branches and it always returns a minor bump. I passed a custom whatBump function to see what commits it was pulling and it seemed to pull the whole history from the main branch (where I branched from). The commit list was 680+ commits long!

I think it would be easy to be able to pass a commit message string to the function as an option. From what I got from the docs it is not possible, is it? If not, would you be open to a PR that would make this possible?

@veloware
Copy link

also experiencing this, did you ever get around it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants