fix: support BREAKING-CHANGE alongside BREAKING CHANGE #882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…king changes As mentioned in https://www.conventionalcommits.org/en/v1.0.0/#specification paragraph 16: “BREAKING-CHANGE MUST be synonymous with BREAKING CHANGE, when used as a token in a footer.”
|
@jeandeaual this seems like a good fix, but it seems to be breaking some tests. |
@bcoe Sorry for that, it should be be fine now. |
bcoe
approved these changes
Dec 29, 2021
|
@jeandeaual thank you for the great contribution 👍 |
This was referenced Dec 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed a discrepancy between the default configuration of the
conventional-changelog-conventionalcommitsandconventional-commits-parserpackages and the Conventional Commits specification.As mentioned in the Conventional Commits v1.0.0 specification paragraph 16: “BREAKING-CHANGE MUST be synonymous with BREAKING CHANGE, when used as a token in a footer.”