-
Notifications
You must be signed in to change notification settings - Fork 710
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support multiple scopes #232
Comments
Probably just
I agree... |
Is this still considered a nice to have feature or could it be taken into consideration for the next major release? I am using multiple scopes in a monorepo and
so a scopeDelimiter option or parsing multiple scopes separately would be really convenient. Thank you |
@dmnsgn we've been gradually moving towards making Conventional Commits a standard, I'm not opposed to supporting multiple scopes, but I would like to see a decision made about supporting it made in Conventional Commits, before we implement anything. I'm working on setting up a monthly meeting for Conventional Commits. |
Looks like commitlint already supports multiple scopes - conventional-changelog/commitlint#901 |
I saw you organized a meeting for earlier today—and let us know if there are any updates from that—, but I didn't see this topic in the proposal/agenda so I opened a feature request with the Conventional Commits spec so it's on the spec project's radar and for discussions to happen there. |
@privatenumber @marionebl I suggest opening an issue on the conventional commits repository, and we can put it on the agenda for the next meeting. |
I did. It's linked above in my previous comment. |
@privatenumber I missed the link, sorry. Thank you, I've added a note to add it to the agenda. |
As raised by @virkt25 in https://github.com/marionebl/commitlint/issues/75, there are use cases for multiple scopes in one commit (think mono repositories):
While downstream tools like commitlint could parse such scopes by splitting with
,
, I'd prefer to see that work done inconventional-commits-parser
, e.g. by providing an appropriate parser preset.Things I am not sure about:
msg.scope
bestring | string[]
or juststring[]
?scopeDelimiter
?The text was updated successfully, but these errors were encountered: