Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multiple scopes #232

Open
marionebl opened this issue Oct 5, 2017 · 8 comments
Open

Support multiple scopes #232

marionebl opened this issue Oct 5, 2017 · 8 comments
Assignees

Comments

@marionebl
Copy link
Contributor

As raised by @virkt25 in https://github.com/marionebl/commitlint/issues/75, there are use cases for multiple scopes in one commit (think mono repositories):

feat(pkg1, pkg2): add some new feature

While downstream tools like commitlint could parse such scopes by splitting with ,, I'd prefer to see that work done in conventional-commits-parser, e.g. by providing an appropriate parser preset.

Things I am not sure about:

  • Should msg.scope be string | string[] or just string[]?
  • Should we introduce a new optional config key for scope splitting, e.g. scopeDelimiter?
@stevemao
Copy link
Member

stevemao commented Oct 5, 2017

Should msg.scope be string | string[] or just string[]?

Probably just string[]

Should we introduce a new optional config key for scope splitting, e.g. scopeDelimiter?

I agree...

@dmnsgn
Copy link

dmnsgn commented Jun 11, 2020

Hi @bcoe @tommywo ,

Is this still considered a nice to have feature or could it be taken into consideration for the next major release?

I am using multiple scopes in a monorepo and fix(cli) fix(app) get translated as cli) fix(app:.
I have seen people using different variant of multiple scopes:

  • type(scope) type(scope)
  • type(scope, scope)
  • type(scope/scope)

so a scopeDelimiter option or parsing multiple scopes separately would be really convenient.

Thank you

@bcoe
Copy link
Member

bcoe commented Jun 11, 2020

@dmnsgn we've been gradually moving towards making Conventional Commits a standard, I'm not opposed to supporting multiple scopes, but I would like to see a decision made about supporting it made in Conventional Commits, before we implement anything.

I'm working on setting up a monthly meeting for Conventional Commits.

@WebMex
Copy link

WebMex commented Aug 6, 2020

Looks like commitlint already supports multiple scopes - conventional-changelog/commitlint#901
Looking forward for the support it by conventional-commits-parser.

@privatenumber
Copy link
Contributor

privatenumber commented Oct 9, 2020

@bcoe

I saw you organized a meeting for earlier today—and let us know if there are any updates from that—, but I didn't see this topic in the proposal/agenda so I opened a feature request with the Conventional Commits spec so it's on the spec project's radar and for discussions to happen there.

conventional-commits/conventionalcommits.org#302

@bcoe
Copy link
Member

bcoe commented Oct 15, 2020

@privatenumber @marionebl I suggest opening an issue on the conventional commits repository, and we can put it on the agenda for the next meeting.

@privatenumber
Copy link
Contributor

I did. It's linked above in my previous comment.

@bcoe
Copy link
Member

bcoe commented Oct 16, 2020

@privatenumber I missed the link, sorry. Thank you, I've added a note to add it to the agenda.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

6 participants