Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cli] missing tests for cwd argument in cli #997

Open
1 task done
armano2 opened this issue Feb 12, 2020 · 0 comments
Open
1 task done

[cli] missing tests for cwd argument in cli #997

armano2 opened this issue Feb 12, 2020 · 0 comments
Labels

Comments

@armano2
Copy link
Contributor

armano2 commented Feb 12, 2020

currently cli argument --cwd is not tested, we should add some tests to ensure that its working.

Affected packages

  • all

Context

After this refactoring to typescript there can be some side effect of how cwd is handled in some of modules, i found it while doing refactoring of cli in #978

const input = await (fromStdin
? stdin()
: read({
to: flags.to,
from: flags.from,
edit: flags.edit,
cwd: flags.cwd
}));

const range = pick(flags, 'edit', 'from', 'to');
const input = await (fromStdin ? stdin() : read(range, {cwd: flags.cwd}));

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

2 participants