Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: enable import/no-extraneous-dependencies #983

Conversation

armano2
Copy link
Contributor

@armano2 armano2 commented Feb 9, 2020

enable import/no-extraneous-dependencies with some notes

Description

This is not working on windows machines - import-js/eslint-plugin-import#1650
and is not reporting all errors due to - import-js/eslint-plugin-import#1104

Motivation and Context

Usage examples

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@armano2 armano2 force-pushed the eslint/no-extraneous-dependencies branch from 2e6e797 to 96ca83c Compare January 9, 2021 09:15
@armano2 armano2 marked this pull request as ready for review January 9, 2021 09:15
@escapedcat escapedcat merged commit 66bfb8e into conventional-changelog:master Jan 11, 2021
@armano2 armano2 deleted the eslint/no-extraneous-dependencies branch January 11, 2021 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants