Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(load): add support for non-factory conventional parsers #839

Merged
merged 1 commit into from Oct 22, 2019

Conversation

byCedric
Copy link
Member

Description

It's kind of weird how Node exits randomly, without proper warnings/errors, when a Promise is never resolved. This happened because the older conventional-changelog-conventionalcommits is used. This adds a fallback-support for when this happens instead of just quitting.

Motivation and Context

Usage examples

How Has This Been Tested?

Added a special test for older parser presets that do not support the callback-factory.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@byCedric byCedric merged commit 3ed8009 into master Oct 22, 2019
@byCedric byCedric deleted the fix/conventional-non-factory-preset branch October 22, 2019 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant