fix slash in scope #291

[escapedcat]

Tried to narrow this down.

Description

Using this scope Modules\Graph with the pascal-case rule fails.

In @commitlint/rules/src/scope-case.js:
const r = ensure.case(scope, check.case); this returns false for such case.

First I only try to add a test-case which would be suitable for this situation. If this is correct we could chech where a fix in case.js coudl be implemented.

Currently thsi test fails:

✖ case › true for Modules/Graph on pascal-case

[escapedcat]

@marionebl
@byCedric
I tried to dig into https://github.com/marionebl/commitlint/issues/291
Narrowed it down and tried to first write a test which shoudl cover that case and shoudl work in the future.
Feedback appreciated :)

[byCedric]

I like the tests-first approach! 👍 I've also dug a bit deeper into @commitlint/ensure to find out why this is happening. Well, I think I have found something. In the ensure.case function, I see that it cleans some special chars and detects empty/numeric values. But I also noticed that Lodash is being used here, which might explain the issue here.

Lodash camelCase is not treating string feature/my-branch as separate words. Instead, it strips out the dash / and converts the letters. So, camelCase('feature/my-branch') === 'featureMyBranch' instead of 'feature/myBranch'

A solution that comes to mind is trying to split the branch name based on either one of the dashes (/ or \). By splitting them, we can still use Lodash without causing this side effect. I think this behavior matches the folder-like structure some Git clients use for branch names. What do you guys think?

[byCedric]

I created the solution I explained earlier, wanted to see if it could work. And well, all tests are in the green. 😄

Replace in file ensure/src/case.js, line 11 the transformed code with this:

	const delimiters = /(\/|\\)/g;
	const transformed = input.split(delimiters)
		.map(segment => delimiters.test(segment) ? segment : toCase(segment, target))
		.join('');

This expects either a / or \ character and splits it into separate words. Because it's split, underscore handles it as we would expect. If you only want to allow / as a delimiter, you can remove the delimiters regex, remove the delimiters test, use .split('/') and use .join('/').

[escapedcat]

Mind blown. You want to add that code? Added you as a collaborator on my fork. Or you branch out from this one.

[byCedric]

Haha, nice 😄 I've added the code! Is this something that we can use or do you know other solutions?