Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: actionable error message for BREAKING CHANGE subject #3810

Open
2 of 4 tasks
abitrolly opened this issue Dec 2, 2023 · 1 comment · May be fixed by #3838
Open
2 of 4 tasks

feat: actionable error message for BREAKING CHANGE subject #3810

abitrolly opened this issue Dec 2, 2023 · 1 comment · May be fixed by #3838
Labels
feature

Comments

@abitrolly
Copy link
Contributor

abitrolly commented Dec 2, 2023 •
edited

Expected Behavior

⧗   input: BREAKING CHANGE: use recommended `heroku/builder:22`
https://github.com/heroku/cnb-builder-images#available-images
✖   move BREAKING CHANGE to footer [change-in-subject]
✖   add type [type-empty]
✖   add subject [subject-empty]
✖   found 2 problems, 0 warnings

Current Behavior

⧗   input: BREAKING CHANGE: use recommended `heroku/builder:22`
https://github.com/heroku/cnb-builder-images#available-images
✖   subject may not be empty [subject-empty]
✖   type may not be empty [type-empty]
✖   found 2 problems, 0 warnings

Affected packages

  • cli
  • core
  • prompt
  • config-angular

Possible Solution

No response

Context

https://gitlab.com/gitlab-org/cluster-integration/auto-build-image/-/merge_requests/159#note_1672887099
@escapedcat
Copy link
Member

Happy for a PR.
You can always use the ! option.

@abitrolly abitrolly mentioned this issue Jan 4, 2024
Open
abitrolly added a commit to abitrolly/commitlint that referenced this issue Jan 4, 2024
@abitrolly
feat: add rule for BREAKING CHANGE: in subject
c3bd59d 
`BREAKING CHANGE:` is a footer thing

Fixed conventional-changelog#3810
@abitrolly abitrolly linked a pull request Jan 4, 2024 that will close this issue
Draft
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add rule for BREAKING CHANGE: in header abitrolly/commitlint
2 participants
@escapedcat @abitrolly