You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
joberstein
changed the title
fix: Message scopes validation for forbidden scopes is incorrect
fix: Message scope validation for forbidden scopes is incorrect
Nov 17, 2023
Once this error is covered, conventional changelog angular 7.x could be finally released and this could resolve these issues #3698 and release-it/conventional-changelog#70
Once this error is covered, conventional changelog angular 7.x could be finally released and this could resolve these issues #3698 and release-it/conventional-changelog#70
@silversonicaxel this issue was pre-existing so the conventional changelog angular upgrade can be done without addressing it.
Reference documentation: https://github.com/conventional-changelog/commitlint/blob/36c58e3d0ba677280a17388cb5bbf58f4627a56a/docs/reference-rules.md#scope-enum
Expected Behavior
If any of the forbidden ('never') scopes are supplied as message scopes, the scope-enum validator should fail. Otherwise, it should pass.
Current Behavior
The scope-enum validator fails only if all of the message scopes are listed as forbidden ('never') scopes. Otherwise, it passes.
Affected packages
Possible Solution
Rework the scope-enum 'never' validation to be it's own condition, not simply the negation of the 'always' validation.
Steps to Reproduce
Context
Discovered in PR: #3725 as a result of failing tests.
commitlint --version
@commitlint/rules@18.4.0
git --version
2.41.0
node --version
20.9.0
The text was updated successfully, but these errors were encountered: