Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate config better #263

Closed
marionebl opened this issue Feb 1, 2018 · 2 comments
Closed

Validate config better #263

marionebl opened this issue Feb 1, 2018 · 2 comments
Labels
enhancement

Comments

@marionebl
Copy link
Contributor

marionebl commented Feb 1, 2018 •
edited by byCedric

commitlint is bound to become increasingly complex and already creates confusion for less common use cases. This is made worse by commitlint accepting unknown config keys:

Expected Behavior

  • Throw when unknow config keys are encountered
  • Be extra helpful when
    • a rule name is encountered in the root object
    • issuePrefixes is provided outside of parserPreset.parserOpts

Current Behavior

  • Unknown config keys are accecpted without error

Possible Solution

  • JSONSchema (compare webpack)
@byCedric byCedric mentioned this issue Oct 20, 2019
Open
4 tasks
@armano2 armano2 mentioned this issue Jan 15, 2021
Open
@armano2 armano2 mentioned this issue Nov 29, 2021
Merged
7 tasks
@armano2
Copy link
Contributor

armano2 commented Dec 8, 2021

@escapedcat fixed as for #2412

@escapedcat
Copy link
Member

Right, thanks @armano2 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Milestone
No milestone
Development

No branches or pull requests
3 participants
@armano2 @escapedcat @marionebl