Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove esbuild@0.11.x from dependency list #204

Merged
merged 2 commits into from May 11, 2022
Merged

Remove esbuild@0.11.x from dependency list #204

merged 2 commits into from May 11, 2022

Conversation

nayaabkhan
Copy link
Contributor

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Apr 30, 2022 •
edited

⚠️ No Changeset found

Latest commit: 36afcfb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

nayaabkhan
nayaabkhan commented Apr 30, 2022
View reviewed changes
packages/@contentlayer/core/package.json
@@ -14,7 +14,7 @@
},
"peerDependencies": {
"date-fns": "2.x",
"esbuild": "0.11.x || 0.12.x || 0.13.x",
"esbuild": "^0.12.1 || 0.13.x",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've not tested if this way of specifying the versions works.

nayaabkhan
nayaabkhan commented Apr 30, 2022
View reviewed changes
packages/@contentlayer/core/package.json
@@ -33,7 +33,7 @@
"camel-case": "^4.1.2",
"comment-json": "^4.2.2",
"date-fns": "2.x",
"esbuild": "0.11.x || 0.12.x || 0.13.x || 0.14.x",
"esbuild": "^0.12.1 || 0.13.x || 0.14.x",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've not tested if this way of specifying the versions works.

@schickling
Copy link
Collaborator

Could you please provide some explanation/motivation for this change? Which problem are you trying to address with this? (Please refer to the corresponding issues.)

@nayaabkhan
Copy link
Contributor Author

Reproduction repo: #205 (comment)

@nayaabkhan
Copy link
Contributor Author

Could you please provide some explanation/motivation for this change? Which problem are you trying to address with this? (Please refer to the corresponding issues.)

This change fixes an error caused by older version of esbuild. See #205.

@schickling schickling marked this pull request as ready for review May 11, 2022 09:04
@schickling schickling merged commit c60847c into contentlayerdev:main May 11, 2022
@nayaabkhan nayaabkhan deleted the patch-1 branch May 11, 2022 09:06
@schickling
Copy link
Collaborator

Thanks a lot for this PR and corresponding issue! Very helpful! 🙏

Will be released as part of the upcoming 0.2.5.

@nayaabkhan
Copy link
Contributor Author

No problemo! Very happy to help out.

@schickling schickling added this to the 0.2.5 milestone May 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.2.5
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nayaabkhan @schickling