build(release): run npm publish directly #424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
z0al
commented
Dec 1, 2022
package.json
Outdated
| @@ -22,7 +22,7 @@ | |||
| "prettier:check": "prettier --check '**/*.{jsx,js,ts,tsx,md,mdx}'", | |||
| "prebuild": "lerna run prebuild", | |||
| "lerna:version": "lerna version --no-private --conventional-commits --create-release github --yes", | |||
| "lerna:publish": "lerna publish from-git --yes", | |||
| "lerna:publish": "npx lerna exec -- npm publish", | |||
There was a problem hiding this comment.
using npx instead of yarn for this step as yarn seems to not respect .npmrc for some reason.
There was a problem hiding this comment.
cool literally commented on this the same time you did haha #424 (comment)
There was a problem hiding this comment.
Umm... thinking about it again, I think this may fail in CI because we run yarn lerna:publish 馃
There was a problem hiding this comment.
Gonna add this command in the config.yaml directly. At least there I can add a comment explaining why
aodhagan-cf
reviewed
Dec 1, 2022
aodhagan-cf
approved these changes
Dec 1, 2022
|
Size Change: 0 B Total Size: 237 kB 鈩癸笍 View Unchanged
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lerna publish --from-gitfails with 404 error. This doesn't happen locally so it's hard to debug. While searching I noticed that we don't need lerna to publish since all the version bumping + changelog + GH release happens in thelerna versionstep.So for our use case,
lerna publishshould be the same as runningnpm publishin all packages and that's what this PR is about to unblock publishing.Additionally I updated some READMEs to mention
yarninstead ofnpm run.This works locally but will have to wait for the CI 馃馃徎