Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: run tests with Lerna #423

Merged
merged 3 commits into from Dec 1, 2022
Merged

build: run tests with Lerna #423

merged 3 commits into from Dec 1, 2022

Conversation

z0al
Copy link
Member

@z0al z0al commented Dec 1, 2022 •
edited

Additionally, got rid of the use of lodash.get, lodash.flatmap in the contentful-slate-adapter package. Let me know if you think this is a bad idea.

@z0al z0al requested review from DanweDE and a team December 1, 2022 09:57
@github-actions github-actions bot added the tools label Dec 1, 2022
@contentful-automation
Copy link
Contributor

contentful-automation bot commented Dec 1, 2022 •
edited

Size Change: +11 B (0%)

Total Size: 237 kB

ℹ️ View Unchanged
Filename Size Change
./packages/contentful-slatejs-adapter/dist/contentful-slatejs-adapter.es5.js 2.4 kB -21 B (-1%)
./packages/contentful-slatejs-adapter/dist/lib/__test__/contentful-helpers.js 344 B 0 B
./packages/contentful-slatejs-adapter/dist/lib/__test__/contentful-to-slatejs-adapter.test.js 1.64 kB 0 B
./packages/contentful-slatejs-adapter/dist/lib/contentful-to-slatejs-adapter.js 858 B -14 B (-2%)
./packages/contentful-slatejs-adapter/dist/lib/helpers.js 157 B 0 B
./packages/contentful-slatejs-adapter/dist/lib/index.js 143 B 0 B
./packages/contentful-slatejs-adapter/dist/lib/schema.js 536 B +64 B (+14%) ⚠️
./packages/contentful-slatejs-adapter/dist/lib/slatejs-to-contentful-adapter.js 1.01 kB -18 B (-2%)
./packages/contentful-slatejs-adapter/dist/lib/types/index.js 64 B 0 B
./packages/contentful-slatejs-adapter/dist/lib/types/slate.js 67 B 0 B
./packages/rich-text-from-markdown/dist/lib/__test__/helpers.js 640 B 0 B
./packages/rich-text-from-markdown/dist/lib/__test__/index.test.js 2.35 kB 0 B
./packages/rich-text-from-markdown/dist/lib/__test__/real-world.test.js 2.58 kB 0 B
./packages/rich-text-from-markdown/dist/lib/index.js 3.83 kB 0 B
./packages/rich-text-from-markdown/dist/lib/types/index.js 125 B 0 B
./packages/rich-text-from-markdown/dist/lib/types/modules.js 55 B 0 B
./packages/rich-text-from-markdown/dist/rich-text-from-es5.js 176 kB 0 B
./packages/rich-text-html-renderer/dist/lib/__test__/documents/embedded-entry.js 310 B 0 B
./packages/rich-text-html-renderer/dist/lib/__test__/documents/heading.js 322 B 0 B
./packages/rich-text-html-renderer/dist/lib/__test__/documents/hr.js 257 B 0 B
./packages/rich-text-html-renderer/dist/lib/__test__/documents/hyperlink.js 309 B 0 B
./packages/rich-text-html-renderer/dist/lib/__test__/documents/index.js 576 B 0 B
./packages/rich-text-html-renderer/dist/lib/__test__/documents/inline-entity.js 376 B 0 B
./packages/rich-text-html-renderer/dist/lib/__test__/documents/invalid-marks.js 282 B 0 B
./packages/rich-text-html-renderer/dist/lib/__test__/documents/invalid-type.js 312 B 0 B
./packages/rich-text-html-renderer/dist/lib/__test__/documents/mark.js 278 B 0 B
./packages/rich-text-html-renderer/dist/lib/__test__/documents/ol.js 321 B 0 B
./packages/rich-text-html-renderer/dist/lib/__test__/documents/paragraph.js 244 B 0 B
./packages/rich-text-html-renderer/dist/lib/__test__/documents/quote.js 257 B 0 B
./packages/rich-text-html-renderer/dist/lib/__test__/documents/table-header.js 410 B 0 B
./packages/rich-text-html-renderer/dist/lib/__test__/documents/table.js 399 B 0 B
./packages/rich-text-html-renderer/dist/lib/__test__/documents/ul.js 322 B 0 B
./packages/rich-text-html-renderer/dist/lib/__test__/index.test.js 1.86 kB 0 B
./packages/rich-text-html-renderer/dist/lib/index.js 1.56 kB 0 B
./packages/rich-text-html-renderer/dist/rich-text-html-es5.js 4.88 kB 0 B
./packages/rich-text-links/dist/lib/__test__/index.test.js 1.22 kB 0 B
./packages/rich-text-links/dist/lib/index.js 1.11 kB 0 B
./packages/rich-text-links/dist/rich-text-links.es5.js 1.12 kB 0 B
./packages/rich-text-plain-text-renderer/dist/lib/__test__/index.test.js 960 B 0 B
./packages/rich-text-plain-text-renderer/dist/lib/index.js 1.27 kB 0 B
./packages/rich-text-plain-text-renderer/dist/rich-text-plain-text-es5.js 3.83 kB 0 B
./packages/rich-text-react-renderer/dist/lib/__test__/components/js 287 B 0 B
./packages/rich-text-react-renderer/dist/lib/__test__/components/Paragraph.js 287 B 0 B
./packages/rich-text-react-renderer/dist/lib/__test__/components/Strong.js 287 B 0 B
./packages/rich-text-react-renderer/dist/lib/__test__/documents/embedded-entry.js 310 B 0 B
./packages/rich-text-react-renderer/dist/lib/__test__/documents/heading.js 322 B 0 B
./packages/rich-text-react-renderer/dist/lib/__test__/documents/hr.js 257 B 0 B
./packages/rich-text-react-renderer/dist/lib/__test__/documents/hyperlink.js 309 B 0 B
./packages/rich-text-react-renderer/dist/lib/__test__/documents/index.js 632 B 0 B
./packages/rich-text-react-renderer/dist/lib/__test__/documents/inline-entity.js 376 B 0 B
./packages/rich-text-react-renderer/dist/lib/__test__/documents/invalid-marks.js 282 B 0 B
./packages/rich-text-react-renderer/dist/lib/__test__/documents/invalid-type.js 312 B 0 B
./packages/rich-text-react-renderer/dist/lib/__test__/documents/mark.js 278 B 0 B
./packages/rich-text-react-renderer/dist/lib/__test__/documents/multi-mark.js 290 B 0 B
./packages/rich-text-react-renderer/dist/lib/__test__/documents/ol.js 321 B 0 B
./packages/rich-text-react-renderer/dist/lib/__test__/documents/paragraph.js 244 B 0 B
./packages/rich-text-react-renderer/dist/lib/__test__/documents/quote.js 257 B 0 B
./packages/rich-text-react-renderer/dist/lib/__test__/documents/table-header.js 410 B 0 B
./packages/rich-text-react-renderer/dist/lib/__test__/documents/table.js 399 B 0 B
./packages/rich-text-react-renderer/dist/lib/__test__/documents/ul.js 322 B 0 B
./packages/rich-text-react-renderer/dist/lib/__test__/index.test.js 2.46 kB 0 B
./packages/rich-text-react-renderer/dist/lib/index.js 1.17 kB 0 B
./packages/rich-text-react-renderer/dist/lib/util/appendKeyToValidElement.js 267 B 0 B
./packages/rich-text-react-renderer/dist/lib/util/nodeListToReactComponents.js 599 B 0 B
./packages/rich-text-react-renderer/dist/rich-text-react-es5.js 4.38 kB 0 B
./packages/rich-text-types/dist/__test__/index.test.js 587 B 0 B
./packages/rich-text-types/dist/__test__/schemaConstraints.test.js 564 B 0 B
./packages/rich-text-types/dist/blocks.js 478 B 0 B
./packages/rich-text-types/dist/emptyDocument.js 361 B 0 B
./packages/rich-text-types/dist/helpers.js 489 B 0 B
./packages/rich-text-types/dist/index.js 792 B 0 B
./packages/rich-text-types/dist/inlines.js 314 B 0 B
./packages/rich-text-types/dist/marks.js 291 B 0 B
./packages/rich-text-types/dist/nodeTypes.js 127 B 0 B
./packages/rich-text-types/dist/schemaConstraints.js 1.12 kB 0 B
./packages/rich-text-types/dist/schemas/__test__/helpers.test.js 371 B 0 B
./packages/rich-text-types/dist/schemas/__test__/schemas.test.js 425 B 0 B
./packages/rich-text-types/dist/schemas/index.js 274 B 0 B
./packages/rich-text-types/dist/types.js 124 B 0 B

DanweDE
DanweDE approved these changes Dec 1, 2022
View reviewed changes
Copy link
Collaborator

@DanweDE DanweDE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be good, flatmap is just being used in adapter anyways, so not worried about browser support here.

@z0al
Copy link
Member Author

z0al commented Dec 1, 2022

Should be good, flatmap is just being used in adapter anyways, so not worried about browser support here.

It has great browser support regardless :)
image

@z0al z0al merged commit a90d405 into master Dec 1, 2022
@z0al z0al deleted the fix-tests branch December 1, 2022 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanweDE DanweDE DanweDE approved these changes

Assignees
No one assigned
Labels
package:contentful-slatejs-adapter package:rich-text-from-markdown package:rich-text-html-renderer package:rich-text-links package:rich-text-plain-text-renderer package:rich-text-react-renderer package:rich-text-types tools
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@z0al @DanweDE