Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

馃挕 Proposal - allow Multiselect component to accept disabled state #2396

Open
msieroslawska opened this issue Feb 2, 2023 · 2 comments
Open

馃挕 Proposal - allow Multiselect component to accept disabled state #2396

msieroslawska opened this issue Feb 2, 2023 · 2 comments
Labels
component:autocomplete proposal stale Used to mark when there was no activity for a set period of time

Comments

@msieroslawska
Copy link
Contributor

msieroslawska commented Feb 2, 2023 •
edited

Forma 36 contribution proposal

The problem

We are currently using Autocomplete component for multiselection, but we would like to migrate it properly to Multiselect. In our case we are using isDisabled prop for Autocomplete to block the whole component before user interacts with another component which then triggers data fetching to populate our Autocomplete. Unfortunately, current implementation of Multiselect only allows disabling single options in the dropdown.

The proposed solution

Expand the interface of Multiselect to accept disabled state which controls if the whole component can be interacted with, similar to the current behavior of Autocomplete:

Screenshot 2023-02-02 at 14 49 04

Breaking changes

None.
@msieroslawska msieroslawska added proposal needs review Proposal/bug that needs to be reviewed by maintainers labels Feb 2, 2023
@github-actions
Copy link

github-actions bot commented Mar 5, 2023

Marking issue as stale since there was no activity for 30 days

@github-actions github-actions bot added the stale Used to mark when there was no activity for a set period of time label Mar 5, 2023
@Lelith Lelith added component:autocomplete and removed needs review Proposal/bug that needs to be reviewed by maintainers stale Used to mark when there was no activity for a set period of time labels Apr 5, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented May 6, 2024

Marking issue as stale since there was no activity for 30 days

@github-actions github-actions bot added the stale Used to mark when there was no activity for a set period of time label May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component:autocomplete proposal stale Used to mark when there was no activity for a set period of time
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Lelith @msieroslawska