Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

馃悰 Bug - Text component should not take "color" prop #2339

Open
denkristoffer opened this issue Nov 24, 2022 · 4 comments
Open

馃悰 Bug - Text component should not take "color" prop #2339

denkristoffer opened this issue Nov 24, 2022 · 4 comments
Labels
bug Something isn't working as expected stale Used to mark when there was no activity for a set period of time

Comments

@denkristoffer
Copy link
Collaborator

denkristoffer commented Nov 24, 2022 •
edited

Forma 36 bug report

Summary

The Text component should not take the prop color but instead throw a type error. I keep using color instead of fontColor because I'm silly and I never get an error, but I don't get the result I expect either 馃檨 The prop type comes from the fact that we're extending the default HTML attributes. We should probably Omit color.

Example: https://f36.contentful.com/playground?code=N4Igxg9gJgpiBcICWBbADhATgFwATFwDEAbGADwBpcAVcvAX1wDNMIVcByAAUgDtsY-JgFdiAeiYBmAGwBaSOgi9B2AM4cA3AB1eO8hhy5YTAIai8I3mGxIluAIJo0ACgCU+HblyYY2YZl5cAB4ScmZSMgARJB9rW14AXi1wCGJhFF0QAD5PL2DaMjxIYiwkkB8oAFYABmrkrIBJXFUACwhRKFxsFtYAd1wTLoBPNBhcGExWTABCILEC7BzAvKCF5iVsAGFU0uSKmrrsptb24k6AIzGK2fm6Ja850LIl+hB6IA
@denkristoffer denkristoffer added the bug Something isn't working as expected label Nov 24, 2022
@github-actions
Copy link

Marking issue as stale since there was no activity for 30 days

@github-actions github-actions bot added the stale Used to mark when there was no activity for a set period of time label Dec 25, 2022
@Wake1st
Copy link
Contributor

Wake1st commented Jan 2, 2023

@denkristoffer, could you provide an example of how you're passing in color - is it via style prop?

@github-actions github-actions bot removed the stale Used to mark when there was no activity for a set period of time label Jan 3, 2023
@denkristoffer
Copy link
Collaborator Author

Thanks for requesting that @Wake1st, I've added an example to the issue.

@github-actions
Copy link

github-actions bot commented Feb 3, 2023

Marking issue as stale since there was no activity for 30 days

@github-actions github-actions bot added the stale Used to mark when there was no activity for a set period of time label Feb 3, 2023
@denkristoffer denkristoffer mentioned this issue May 11, 2023
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working as expected stale Used to mark when there was no activity for a set period of time
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@denkristoffer @Wake1st