Fixed an IndexError: list assignment index out of range error in RichTextField coersion
#52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…chTextField._coerce_block due to removing items by index from a list from the front causing the indexes to no longer be valid.
|
Thanks for fixing this! Merging! Cheers |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed an
IndexError: list assignment index out of rangeerror inRichTextField._coerce_block, which was due to removing items by index from the front of a list causing the indexes to no longer be valid.If you have a list:
['a', 'b', 'c']and you want to remove the values at indexes1and2, if you remove the value at index1, then the list size shrinks by one and the index2is outside of the list. My fix just does the trimming from the end of the list, so the indexes are still consistent with the size of the list at the time they are removed.