Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(entry): return None if the nested link is unresolvable #59

Merged
merged 2 commits into from Jul 16, 2020
Merged

fix(entry): return None if the nested link is unresolvable #59

merged 2 commits into from Jul 16, 2020

Conversation

Spring3
Copy link
Contributor

@Spring3 Spring3 commented Jul 14, 2020

resolved #58

@Spring3 Spring3 requested a review from dlitvakb July 14, 2020 16:02
@Spring3 Spring3 self-assigned this Jul 14, 2020
freakyfelt
freakyfelt approved these changes Jul 15, 2020
View reviewed changes
Copy link

@freakyfelt freakyfelt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving as this seems to be in line with existing behaviour in the SDK for unresolved entries in other locations

@freakyfelt
Copy link

@dlitvakb any idea how to make travis-ci happy? Looks like py3.4 is no longer supported by PyYAML

PyYAML requires Python '>=2.7, !=3.0., !=3.1., !=3.2., !=3.3., !=3.4.*' but the running Python is 3.4.8

@dlitvakb
Copy link
Contributor

Yeah, I was updating this, Python 3.4 is already EOL, so I'm removing it and adding 3.8 to the list. But meetings and a software update blocked me 😅

@dlitvakb dlitvakb merged commit 261f675 into master Jul 16, 2020
@dlitvakb dlitvakb deleted the fix/unresolved-nested-links-as-none branch July 16, 2020 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@freakyfelt freakyfelt freakyfelt approved these changes

@dlitvakb dlitvakb dlitvakb approved these changes

Assignees

@Spring3 Spring3

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Draft content is returned from entries
3 participants
@Spring3 @freakyfelt @dlitvakb